-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
modified governance document #2442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👷 Deploy request for selenium-dev pending review.Visit the deploys page to approve it
|
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
the governance document - can contain other roles defined in structure example - Conference Committee - https://www.selenium.dev/project/structure/ |
should the repository of selenium client bindings be called seleniumclientbindings, or seleniumbindings , if PLC thinks that is helpful. we define committers as per repository / area to where people are contributing to. example selenium docker repository. so that it becomes self explanatory. |
the blogs which we put out for releases has a section called as Selenium Team, there is no mention of Selenium Team in governance document. I think communications from project may think about being aligned to governance document described roles. - example - https://www.selenium.dev/blog/2025/selenium-4-35-released/ |
the selenium communication channels might need a check - google group, librechat, matrix, slack etc (links and names). using twitter for congratulations? or slack or linkedin? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the PR so it is easier to evaluate.
Note that this documents the official governance as voted on by PLC, so it can't be merged until a vote has been made to change it.
Aware of it, plc asked creation so it becomes easier to see diff. So this PR. |
This is a good document could help for this doc as well- https://webkit.org/commit-and-review-policy/ |
<li><a href="#documenters">Documenters</a></li> | ||
<li><a href="#translators">Translators</a></li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the reason for removing these two roles? Can you please elaborate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please relook at the description of Contributors in the existing document. In the definition of that role we already mention about contributing to code/documentation.
I find these two roles redundant, and i have viewed few other open source projects roles, i gave a link as reference used, we can avoid having documenters and translators as separate and have contributors . current contributors definition already have that information.
incase the role of documenters and translators are to required explicitly, then what path do they take ? will any number of contributions from documenter or translator give them path to committer? or these roles will just stay as is it? are these sub categories of contributor?
i remember the earlier version of the governance doc when these roles were not defined, it used to make more sense to me. that version existed i believe before these two roles were created.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those roles were intended to clarify how community members could contribute to the project. Most of the time, the committer role suggests that you need to write code, and these two roles emphasize that "you do not only need to write code to contribute to this project".
Documenters and Translators are also repository committers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Diego, i have understood why these roles were created. it has been explained to me, more than once, here and in the plc channel. I found contributor role already having that information, and it could be written better to allow community to understand what all are various ways to contribute to the project.
I felt this would help simplify governance doc, that was all. I am sorry i won't be able to repeat this again and again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the clarification, Pallavi. I wasn’t aware that this had already been explained to you in Slack. I can’t always follow all the threads, so I appreciate you flagging that. Given that the reasoning behind these roles has already been clarified, I’m just trying to understand what’s prompting the change now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thats alright Diego, im sorry as well. I didn't realize that.
i will try to explain ... although i have said it before... or maybe i haven't been clear.. i will try one last time.
a. if we define who is a contributor better, which i have tried to do in the PR, and cover aspects of contribution other than code, which we do in that role already we don't need these two separate roles.
b. simplifies governance document, and maybe aligns it with common roles found in open source projects.
thats is all.
i am sorry i don't understand what else i can say more in here to explain this request. if this doesn't make sense kindly close it. i found the roles unnecessary and extra.
i understand the reasoning , even then i have my views. so i expressed. hope this helps.
@@ -60,30 +83,30 @@ <h3 id="users">Users</h3> | |||
<h3 id="contributors">Contributors</h3> | |||
|
|||
Contributors are community members who contribute in concrete ways to the project, | |||
most often in the form of code and/or documentation. Anyone can become a Contributor, | |||
and contributions can take many forms, e.g.: | |||
most often in the form of code and/or documentation in the respective project repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if this level of detail is necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
</li> | ||
</ul> | ||
|
||
<p> | ||
There is no expectation of commitment to the project, no specific skill requirements, | ||
and no selection process. | ||
Some Contributors might have some basic privileges to the GitHub repos, based on | ||
Some Contributors might have some basic privileges to the GitHub repos to which they have contributed, based on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If they are contributors, it is because they have contributed. This phrase is redundant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
@@ -105,7 +128,7 @@ <h3 id="contributors">Contributors</h3> | |||
<div class="pb-5"> | |||
<h3 id="triagers">Triagers</h3> | |||
As contributors grow into the project they will be added as members of the triage team. Their | |||
role is to help triage issues and potentially submit Pull Requests with fixes or at least a | |||
role is to help triage issues and potentially submit Pull Requests in the github repos with fixes or at least a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this level of detail necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think it made it more readable and clear to me. if not necessary please ignore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull requests are submitted to repositories. It is implicit.
i am closing this PR. i find it going in loops. i understand my views are different from what the governance expresses. Thank you for the time here for review of this PR. |
User description
Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.
modified governance document
Description
modified governance document heading.
listed objectives
removed roles of documenters and translators
Motivation and Context
To ease and streamline roles for selenium project, based on generic roles which govern open source projects.
reference link -https://opensource.guide/how-to-contribute/
Types of changes
Checklist
PR Type
Documentation
Description
Restructured governance document with new objectives section
Removed documenter and translator roles from governance structure
Enhanced contributor and committer role descriptions
Improved clarity and organization of governance framework
Diagram Walkthrough
File Walkthrough
_index.html
Restructured governance framework with streamlined roles
website_and_docs/content/project/governance/_index.html